MNT Removed deprecated attributes and parameters -- ctnd #15804
Conversation
|
It seems that there is something wrong with |
|
Green and ready for review @glemaitre @adrinjalali @qinhanmin2014 @thomasjpfan |
|
interesting, why are the scores changed? |
|
Because of min impurity split I would say |
| @@ -479,9 +479,6 @@ def _set_checking_parameters(estimator): | |||
| # K-Means | |||
| estimator.set_params(n_init=2) | |||
|
|
|||
| if hasattr(estimator, "n_components"): | |||
There was a problem hiding this comment.
I could assume that it was to speed up the tests. Is there a reason to remove it?
There was a problem hiding this comment.
We used to raise a warning, but now we error so tests would fail because in some cases 2 was too high.
Since setting it to 1 is not really meaningful, I left it to the default.
There was a problem hiding this comment.
In terms of testing time, pytest sklearn/tests/test_common.py -k LinearDiscriminantAnalysis goes from 4.9 secs to 5.2 secs on my machine so that's negligible
|
Maybe @thomasjpfan can give this a quick review and then we can finish up #15860? |
|
Thank you @NicolasHug ! |
Need to merge #15803 first