Skip to content

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Dec 9, 2019

Right now the scikit-learn dev version is used inside the binder image when clicking on a binder link from the stable documentation.

For example, if you click on the binder link at the bottom of https://scikit-learn.org/stable/auto_examples/plot_isotonic_regression.html#sphx-glr-auto-examples-plot-isotonic-regression-py and type this inside the notebook:

import sklearn
sklearn.__version__

you'll get:

'0.23.dev0'

@lesteve lesteve added this to the 0.22.1 milestone Dec 9, 2019
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need to do it manually for every release? Is there a better way?

@qinhanmin2014 qinhanmin2014 merged commit bf24c7e into scikit-learn:0.22.X Dec 9, 2019
@lesteve lesteve deleted the fix-binder-version branch December 9, 2019 14:46
@lesteve
Copy link
Member Author

lesteve commented Dec 9, 2019

So we need to do it manually for every release? Is there a better way?

I think we need to do it manually for every major release. Actually I should have done scikit-learn==0.21.*, sorry about that. I'll open a new PR.

As you have already commented in #15759, it's probably a good idea to document that in the "how to release" documentation indeed.

@lesteve
Copy link
Member Author

lesteve commented Dec 9, 2019

Actually I should have done scikit-learn==0.21.*, sorry about that. I'll open a new PR.

I opened #15847.

Pseudomanifold pushed a commit to BorgwardtLab/scikit-learn that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants