Skip to content

Label spreading bug fix #15946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 9, 2020
Merged

Label spreading bug fix #15946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2706b2e
Managed the case where the sum by row is zero.
ngshya Dec 21, 2019
2fd9ccb
Managed the case where the sum by row is zero.
ngshya Dec 21, 2019
101e125
Managed the case where the sum by row is zero.
ngshya Dec 21, 2019
f99bf29
Added the non regression test for #15946.
ngshya Dec 22, 2019
bce6500
Solved the issue of long line.
ngshya Dec 22, 2019
607f31f
Removed trailing space.
ngshya Dec 22, 2019
3d0556d
Merge branch 'master' into label_spreading_bug_fix
ngshya Dec 27, 2019
8876b74
removed blank line at the end of the file
ngshya Dec 28, 2019
38b1e58
remove blank lines with spaces
ngshya Dec 28, 2019
855e988
modified normalizer instead of label_distributions_
ngshya Jan 8, 2020
a70d944
more idiomatic numpy way to manage normalizer == 0
ngshya Jan 8, 2020
2db2541
nitpicks
glemaitre Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sklearn/semi_supervised/_label_propagation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ def fit(self, X, y):
self.n_iter_ += 1

normalizer = np.sum(self.label_distributions_, axis=1)[:, np.newaxis]
normalizer[normalizer == 0] = 1
self.label_distributions_ /= normalizer

# set the transduction item
Expand Down
12 changes: 12 additions & 0 deletions sklearn/semi_supervised/tests/test_label_propagation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,18 @@ def test_convergence_warning():
assert_no_warnings(mdl.fit, X, y)


def test_label_propagation_non_zero_normalizer():
# check that we don't divide by zero in case of null normalizer
# non-regression test for
# https://github.com/scikit-learn/scikit-learn/pull/15946
X = np.array([[100., 100.], [100., 100.], [0., 0.], [0., 0.]])
y = np.array([0, 1, -1, -1])
mdl = label_propagation.LabelSpreading(kernel='knn',
max_iter=100,
n_neighbors=1)
assert_no_warnings(mdl.fit, X, y)


def test_predict_sparse_callable_kernel():
# This is a non-regression test for #15866

Expand Down