Skip to content

DOC fix docstring in semi_supervised module following doc guideline #16042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2020

Conversation

shubchat
Copy link
Contributor

@shubchat shubchat commented Jan 7, 2020

Reference Issues/PRs

related to #15761

What does this implement/fix? Explain your changes.

improve semi_supervised module docstring per guidelines. Addresses all classes and functions under sklearn/semi_supervised

@shubchat shubchat changed the title [WIP]DOC follow doc guideline in semi_supervised module [MRG]DOC follow doc guideline in semi_supervised module Jan 7, 2020
@shubchat
Copy link
Contributor Author

Hi, @glemaitre Are there any further edits needed for this to be merged?

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shubchat , a few comments

@shubchat shubchat requested a review from NicolasHug January 12, 2020 19:30
@glemaitre glemaitre self-assigned this Jan 13, 2020
@glemaitre glemaitre changed the title [MRG]DOC follow doc guideline in semi_supervised module DOC fix docstring in semi_supervised module following doc guideline Jan 13, 2020
@glemaitre
Copy link
Member

@shubchat I took the opportunity to correct the default in the methods as well. It looks good. I am waiting for the CI to be green and I will merge.

@glemaitre glemaitre merged commit 594fc85 into scikit-learn:master Jan 13, 2020
@shubchat
Copy link
Contributor Author

@shubchat I took the opportunity to correct the default in the methods as well. It looks good. I am waiting for the CI to be green and I will merge.

Thanks @glemaitre ! :)

@shubchat shubchat deleted the resolve_15761 branch January 14, 2020 18:20
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants