fix default value for class LinearSVC #16077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, mistakenly closed the pull request. reopen it again |
thomasjpfan
reviewed
Jan 9, 2020
| @@ -26,28 +26,28 @@ class LinearSVC(BaseEstimator, LinearClassifierMixin, | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| penalty : str, 'l1' or 'l2' (default='l2') | |||
| penalty : str, 'l1' or 'l2' default='l2' | |||
There was a problem hiding this comment.
Suggested change
| penalty : str, 'l1' or 'l2' default='l2' | |
| penalty : {'l1', 'l2'}, default='l2' |
| Specifies the norm used in the penalization. The 'l2' | ||
| penalty is the standard used in SVC. The 'l1' leads to ``coef_`` | ||
| vectors that are sparse. | ||
|
|
||
| loss : str, 'hinge' or 'squared_hinge' (default='squared_hinge') | ||
| loss : str, 'hinge' or 'squared_hinge', default='squared_hinge' |
There was a problem hiding this comment.
Suggested change
| loss : str, 'hinge' or 'squared_hinge', default='squared_hinge' | |
| loss : {'hinge', 'squared_hinge'}, default='squared_hinge' |
| Regularization parameter. The strength of the regularization is | ||
| inversely proportional to C. Must be strictly positive. | ||
|
|
||
| multi_class : str, 'ovr' or 'crammer_singer' (default='ovr') | ||
| multi_class : str, 'ovr' or 'crammer_singer',default='ovr' |
There was a problem hiding this comment.
Suggested change
| multi_class : str, 'ovr' or 'crammer_singer',default='ovr' | |
| multi_class : {'ovr' or 'crammer_singer'}, default='ovr' |
| Enable verbose output. Note that this setting takes advantage of a | ||
| per-process runtime setting in liblinear that, if enabled, may not work | ||
| properly in a multithreaded context. | ||
|
|
||
| random_state : int, RandomState instance or None, optional (default=None) | ||
| random_state : int, RandomState instance or None, default=None |
There was a problem hiding this comment.
Suggested change
| random_state : int, RandomState instance or None, default=None | |
| random_state : int, RandomState instance, default=None |
|
Already addressed in #16060 which was opened earlier. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix documentation of default values in all classes good first issue help wanted
#15761
What does this implement/fix? Explain your changes.
This is my first contribution. I removed some optional key words and standardized default value as default=. Also I set the default value of class weight to 1 as the specification.
All above changes are made for class LinearSVC
Any other comments?