DOC added the link for the reference in permutation_test_score #16202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
requested changes
Jan 26, 2020
| @@ -1039,6 +1039,8 @@ def permutation_test_score(estimator, X, y, groups=None, cv=None, | |||
| Ojala and Garriga. Permutation Tests for Studying Classifier | |||
| Performance. The Journal of Machine Learning Research (2010) | |||
| vol. 11 | |||
| http://www.jmlr.org/papers/volume11/ojala10a/ojala10a.pdf | |||
There was a problem hiding this comment.
We need to make the link clickable
`[pdf] <http://www.jmlr.org/papers/volume11/ojala10a/ojala10a.pdf>`_
adrinjalali
approved these changes
Feb 3, 2020
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
…t-learn#16202) * added the link for an open pdf of the article * Address comment Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
…t-learn#16202) * added the link for an open pdf of the article * Address comment Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14757
The pull request was reopened for a small fix which was adding a citation link for docstring. I added a link
@adrinjalali @noatamir