diabetes instead of Boston dataset, eg feature selection #16305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into boston_exchange_ex_plot_select_from_model_boston
|
This is how this example is rendered now: https://91364-843222-gh.circle-artifacts.com/0/doc/auto_examples/feature_selection/plot_select_from_model_diabetes.html And recently we have been using some nice features which make an example look like this one: https://scikit-learn.org/dev/auto_examples/inspection/plot_partial_dependence.html#sphx-glr-auto-examples-inspection-plot-partial-dependence-py I'm happy with what you have here, but if you have the time and feel like improving the way the example looks on the website, it'd be awesome :) |
…into boston_exchange_ex_plot_select_from_model_boston
…into boston_exchange_ex_plot_select_from_model_boston
adrinjalali
approved these changes
Feb 3, 2020
| the baseline. | ||
|
|
||
| Authors: Manoj Kumar <mks542@nyu.edu> | ||
| Maria Telenczuk |
There was a problem hiding this comment.
you could also point to your github user account page if you want, instead of email. But leaving it as is is also fine.
…into boston_exchange_ex_plot_select_from_model_boston
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #16155
Removed:
examples/feature_selection/plot_select_from_model_boston.py
Introduced instead using diabetes dataset:
examples/feature_selection/plot_select_from_model_diabetes.py
Old final figure:
New final figure:
What does this implement/fix? Explain your changes.
Any other comments?