-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[DOC] Update random_state descriptions for mutual_info, unsupervised, .… (4) #16320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py and utils/init.py
jeremiedbb
reviewed
Jan 30, 2020
jeremiedbb
reviewed
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nitpicks
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
I have addressed your comments @jeremiedbb :D |
adrinjalali
approved these changes
Feb 7, 2020
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
… .… (4) (scikit-learn#16320) * Update random_state doc for mutual_info.py, unsupervised.py, testing.py and utils/init.py * Update comments from pr * Update sklearn/metrics/cluster/_unsupervised.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/utils/__init__.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/utils/__init__.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
… .… (4) (scikit-learn#16320) * Update random_state doc for mutual_info.py, unsupervised.py, testing.py and utils/init.py * Update comments from pr * Update sklearn/metrics/cluster/_unsupervised.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/utils/__init__.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Update sklearn/utils/__init__.py Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue/PR:
partially addressed #10548
Updated the documentation for random_state in :
sklearn/feature_selection/_mutual_info.py - 226, 335, 414
sklearn/metrics/cluster/_unsupervised.py - 80
sklearn/utils/_testing.py - 521
sklearn/utils/init.py - 478, 623
Only added the key sentence :
Pass an int for reproducible output across multiple function calls.
See :term:Glossary <random_state>.