[MRG] DOC plot_partial_dependence_visualisation_api exchanged boston for diabetes dataset #16341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Feb 1, 2020
rth
reviewed
Feb 3, 2020
| ############################################################################## | ||
| # Plotting partial dependence for two features | ||
| # ============================================ | ||
| # | ||
| # We plot partial dependence curves for features "LSTAT" and "RM" for | ||
| # We plot partial dependence curves for features "s1" and "s5" for |
There was a problem hiding this comment.
I think it would be nice to explain what these variables are. The list can be found in https://www.openml.org/d/37 however I'm not sure about the mapping with our feature names. Taking variables that are easy to understand would be ideal.
There was a problem hiding this comment.
I agree, otherwise I'm happy with the changes.
There was a problem hiding this comment.
There looks to be a mapping between our variables to more descriptive features: https://www4.stat.ncsu.edu/~boos/var.select/diabetes.html
…into boston_exchange_eg_plot_partial
…into boston_exchange_eg_plot_partial
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
…abetes dataset (scikit-learn#16341) * exchanged the boston for diabetes dataset loading * updated the feature names * exchanged remaining feature names * cleaning up * changed features used to age and bmi for easier understanding
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
…abetes dataset (scikit-learn#16341) * exchanged the boston for diabetes dataset loading * updated the feature names * exchanged remaining feature names * cleaning up * changed features used to age and bmi for easier understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Towards #16155
exchanges the boston dataset for the diabetes dataset in the given example
Any other comments?