Skip to content

[WIP] Add quantile regression (Continuation) #16343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 37 commits into from

Conversation

DatenBiene
Copy link
Contributor

Reference Issues/PRs

Continuation of PR #9978

Any other comments?

I will try this implementation on several datasets.

David Dale and others added 30 commits October 4, 2017 11:15
@rth
Copy link
Member

rth commented Mar 25, 2020

Hi @DatenBiene ,

let me know if you still plan to work on this. Thanks!

@DatenBiene
Copy link
Contributor Author

Hi Roman @rth, I can work on this project now and will invest some time on it in the next weeks. Could you indicate me how the more helpful I could be on this and what kind of deliverable you expect? (Benchmarking with the R implementation? On how many datasets? Are there any rules I need to follow?)

Many thanks!

@rth
Copy link
Member

rth commented Apr 3, 2020

Great @DatenBiene ! There are two main points to start,

  1. Address my review comments from the parent PR [MRG] Add quantile regression #9978 (review) and in particular remove L1 regularization to start with a simple approach.
  2. try this implementation on a couple of classical datasets (say load_diabetes, fetch_california_housing + some regression dataset with known outlier issues) and check that a) it does converge, b) compare the runtime e.g. with respect to Ridge.

@rth
Copy link
Member

rth commented Apr 3, 2020

You should also resolve conflicts in doc/modules/classes.rst (click on "Resolve conflicts").

@rth
Copy link
Member

rth commented Apr 3, 2020

Benchmarking against a well tested R implementation (listed in the parent issue) would also be great.

@DatenBiene
Copy link
Contributor Author

Great ! I'll keep you inform of my improvement/difficulties. Thank you

@lucyleeow
Copy link
Member

Hi @DatenBiene are you still working on this? Thanks

@lorentzenchr lorentzenchr mentioned this pull request Dec 13, 2020
4 tasks
Base automatically changed from master to main January 22, 2021 10:52
@cmarmo cmarmo added Superseded PR has been replace by a newer PR and removed Stalled help wanted labels Apr 2, 2021
@lorentzenchr
Copy link
Member

Solved in #9978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:linear_model Superseded PR has been replace by a newer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants