Skip to content

DOC promote shallow copy in the docs #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

adrinjalali
Copy link
Member

Fixes #16008

Seems like we rather promote a shallow copy instead of touching our git history. This PR puts that in the contributing guides.

@adrinjalali adrinjalali requested review from jnothman and rth February 10, 2020 11:58
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug
Copy link
Member

IMHO this isn't relevant for most contributors and it will add noise to our docs which are already overloaded with info

@adrinjalali
Copy link
Member Author

This (and the default mkl inclusion by conda) were the main issue when I was in Nairobi. Not everybody has access to a fast internet connection, and not including this disproportionately puts those people in a disadvantage.

Even I've had this issue at home, the internet speed and the github servers around the world are not all the same.

@NicolasHug
Copy link
Member

Maybe just remove it from the contributing guide? Its goal is to be as concise as possible and we recently trimmed it down, leaving special cases for other sections

@adrinjalali
Copy link
Member Author

What are the chances of somebody who's reading the contributing guide needing it, compared to somebody who's reading the advanced installation? Doesn't make sense to me to remove it from the contributing guide. If anything, we can remove it from the advanced installation if you want. But I really don't get why you'd argue for not having it.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I liked the earlier version a bit better because it makes it possible to copy and paste the full line in one go.

But I'm fine with both.

@adrinjalali adrinjalali merged commit c79a5b4 into scikit-learn:master Feb 10, 2020
@adrinjalali adrinjalali deleted the doc/shallo-copy branch February 10, 2020 15:45
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
* DOC promote shallow copy in the docs

* a shorter version
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
* DOC promote shallow copy in the docs

* a shorter version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup git repo
4 participants