API make a few estimators' init args kw-only #16474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that ideally we'd apply the change in a single release. Therefore it'd be nice if we move this forward before it gets too close to the release :) |
jnothman
approved these changes
Feb 20, 2020
|
Thanks for pushing this along, @adrinjalali |
|
Nice! Do you think we'll get any feedback from the dev version? I figure people will only notice once we release so I guess we have to just go for it and see what happens? |
|
Yeah. I'll try to write a blog post and tweet and stuff, with links to the nightly build, hopefully that'll give us some feedback. Otherwise since it doesn't really break people's code, if we get the feedback that in certain places we should accept more parameters as positional, then we can just do that in a bug fix release. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
3 tasks
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SLEP009 is accepted, we can start making certain args keyword only. AFAIK we never ended up doing the data-drive-API-design we wanted to do (or did we?). Therefore this PR starts that process by making some of the init args keyword only, in a rather conservative way (or I'd like to think), i.e. it puts the
*after the arg which I feel may be used often w/o its name.One purpose of this PR is for us to get a feeling about how we'd like to proceed, and therefore is not complete and only touches a few estimators.
cc @scikit-learn/core-devs since it touches the API.