Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH Hellinger distance split criterion for classification trees #16478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Hellinger distance split criterion for classification trees #16478
Changes from all commits
9bc7978
a14b889
e2c2bc0
e08fc4f
8d539c6
c3d5951
7412351
4419414
f21ea29
2013677
a85e92e
760d2a4
b92fe7b
4cd790a
5c57f77
9ce5426
78ea842
ac2dea7
8d6bbb2
3b3f053
a4add22
cf54101
514178b
e5fbef8
22ae6e2
b29de9b
fff1a23
24a773d
7b4a6cd
388ed43
bbad3ac
3c23707
f264f8e
30dfd47
43cab10
4d1fdf5
3653687
6197177
9635b7e
8455304
59fbb7f
46c960e
963c177
ea41708
dfc73e0
f8d06a1
7133b84
0bacb62
b9528a9
be106b7
cefe596
31bc121
3e8767d
3016c81
470e65f
05c0605
0c362c2
335f977
2a3df93
2bcfd3d
413d589
0cca18c
c436c10
09b2015
287a049
e495b99
0816ef9
dfd9f21
a1258bc
937f763
47ac904
b7f82a7
5395f9b
a49b794
559e6e5
b9f134e
25a10ae
8038ec7
ce696e6
6a55dee
1debc3b
46cea9b
082975e
33f3e47
4492d92
d361a77
129ba2b
6cb8b49
3249e1b
fd7d480
0b650d1
8b96387
fef29a9
9c91d9c
3599979
53b7fe5
18b950d
510b681
5d6b2ce
dca1e0d
d11baf8
d2f2dee
b06b3f5
61cb61c
c1510cd
049e9c9
e0f7e8c
fa90e25
3a5dda0
e6b6be8
eb14cbb
120e373
44b65e3
85fc45d
ff98b54
d18e191
43d2a5d
c82b847
7a2f49b
82d0ba2
1f178ad
557386f
926e787
828a16c
810a5c0
06cb1f2
1a0450a
10353d1
b249c3f
917687c
cc6bd2e
28b243f
36c0658
81852c5
24a54c5
f9135a3
b02cf78
8a50998
7c374de
08cd53e
625a84f
27a5552
d86cb20
a34f5bc
a0354f6
41ff7e2
a6b7fac
769e604
d86ae83
f9da824
81c7404
30797b7
43fcd99
a5312d9
44c2d2a
e5ceb41
a6f26d4
46a68f8
b62d82f
d29a78d
c3aa70b
885c30a
c039271
f194cf6
eb66a90
ecdacaf
972d7e8
3a77957
bc870db
fa85e6d
0d15d6f
c9e510e
187ca9f
f2cddbc
e480b09
d69e109
20d4ca9
05e94ef
a17f176
9afbfac
23edd32
e255c59
d0a62ae
1a1595a
6869d8e
1320eea
c001573
15452ae
ad981b0
b51605a
1cb0437
433fd59
413252c
9b0426b
19705dc
05720ce
ea63f5f
e0d5b9a
fd3606c
7ba096a
65ae007
7189aed
e5c975a
ca38862
5d7c57e
56c2667
826fb68
342004f
4aef69a
0be10a1
0e11ce1
7439c8f
bf5e981
0adbb57
a2c8519
265158a
a16003d
7bee937
2269b0c
dca75a0
4c8f4ac
187bf58
f93d708
d87e5ec
e2abd47
5d9585d
cc2b53c
fee65eb
1717396
25073c1
e30ea17
f9db7fa
269eaa0
b37a0c8
d9271bd
aee810a
e8d59b5
2207ba1
9a69223
a17cdb1
50430a4
edf52f7
93b00e0
89618a4
cd4f782
0b38f85
4dcf57f
e175cda
438feb8
d66f78c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As proposed, I would improve the following example:
https://scikit-learn.org/stable/auto_examples/svm/plot_separating_hyperplane_unbalanced.html
It would avoid adding a new example. We can make a notebook-style notebook to make it more didactic using the
# %%
markers and adding interlaced explanationd. You can refer to this example for instance: https://github.com/scikit-learn/scikit-learn/blob/main/examples/inspection/plot_linear_model_coefficient_interpretation.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvgeniDubov: I think this suggestion from @glemaitre is left to address.