[MRG] Enable california_housing pandas test in cron job #16547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasjpfan I've created a new PR for mocking pandas as discussed here |
|
Still WIP? A bit convoluted, but in the absence of another solution, lgtm |
|
True - the only other solution I can see is setting up another environment that downloads the datasets, but w/o pandas. Seems excessive to me. |
thomasjpfan
approved these changes
Mar 3, 2020
jnothman
approved these changes
Mar 3, 2020
rth
approved these changes
Mar 4, 2020
|
Sorry something seems to be wrong with commit attribution #16640 (comment) |
|
On one of my machines I use a user.email that I just recently added to my gh profile, which could confuse gh. May or may not be related.. |
ashutosh1919
pushed a commit
to ashutosh1919/scikit-learn
that referenced
this pull request
Mar 13, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #16348
What does this implement/fix? Explain your changes.
In #16348 tests for network datasets were enabled in the Travis Cron job.
This PR enables an additional test on
california_housing, which requirespandasnot to be installed. This is achieved by introducing a mock fixturethat hides available pandas.
Any other comments?