DOC Note on commit co-authorship when merging PRs #16550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Feb 26, 2020
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
|
Thanks @rth |
7 tasks
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short note to raise awareness of @scikit-learn/core-devs that multiple co-authors can be attributed in git when merging PRs. The
Co-authored-bytag pre-filled by Github needs to be kept in the detailed description for it to happen.When to give co-authorship is left it maintainers appreciation, but I think there are at least the following cases where it could make sense to reflect co-authorship in git blame,
Note that Github already does this by default, unless ones removes the detailed commit description when merging PRs.