Skip to content

DOC Note on commit co-authorship when merging PRs #16550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2020
Merged

DOC Note on commit co-authorship when merging PRs #16550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14ffb6
Note on commit co-authorship when merging PRs
rth Feb 26, 2020
3c8b946
Update doc/developers/maintainer.rst
rth Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions doc/developers/maintainer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,24 @@ The following GitHub checklist might be helpful in a release PR::
#15847)
* [ ] announce on mailing list and on twitter

Merging Pull Requests
---------------------

Individual commits are squashed when a Pull Request (PR) is merged on Github.
Before merging,

- the resulting commit title can be edited if necessary. Note
that this will rename the PR title by default.
- the detailed description, containing the titles of all the commits, can
be edited or deleted.
- for PRs with multiple code contributors care must be taken to keep
the `Co-authored-by: name <name@example.com>` tags in the detailed
description. This will mark the PR as having `multiple co-authors
<https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors>`_.
Whether code contributions are significanly enough to merit co-authorship is
left to the maintainer's discretion, same as for the "what's new" entry.


The scikit-learn.org web site
-----------------------------

Expand Down