Skip to content

CI Use "Bug: triage" label for user reports #16560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

rth
Copy link
Member

@rth rth commented Feb 27, 2020

With the introduction of issues templates, new reports of defects have a "Bug" label, while in a number of cases it's not a bug but rather a user question, an intended behaviour etc. This makes the "Bug" label not very reliable or useful.

I propose to use instead the "Bug: triage" label for new bug reports, which can then be changed to "Bug" once it's confirmed. There may be a way to automate that.

@rth rth requested review from glemaitre and thomasjpfan February 27, 2020 11:04
@rth rth changed the title CI Use "Bug: triage" tag for user reports CI Use "Bug: triage" label for user reports Feb 27, 2020
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rth . Have you already added the "Bug: triage" label to the list of labels?

@rth
Copy link
Member Author

rth commented Feb 27, 2020

Have you already added the "Bug: triage" label to the list of labels?

Yes, I did. The only thing is that the label is Bug: triage and I'm not fully sure if simple quotes is the right way to escape a string with spaces in that markdown. They seem to be used for other fields. I guess we'll see once it's merged.

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, but wonder if "Triage" is sufficient?

@rth
Copy link
Member Author

rth commented Feb 27, 2020

Triage sounded a bit more neutral than "Bug: unconfirmed", but I'm open to suggestions for a better label name.

@glemaitre
Copy link
Member

What about "Potential Bug"?

@rth
Copy link
Member Author

rth commented Feb 27, 2020

What about "Potential Bug"?

For me "potential" suggests that it can evolve into an actual bug (https://www.merriam-webster.com/dictionary/potential). While the situation is rather that it's a bug or not and someone need to confirm it, I wouldn't mind having some indication of action of "confirmation required" in the name.

@glemaitre
Copy link
Member

glemaitre commented Feb 27, 2020 via email

@glemaitre
Copy link
Member

To be sure before merging, do we have the tag created already (which should probably make it an orange color :))

@rth
Copy link
Member Author

rth commented Feb 27, 2020

Yes we have it. It's orangish https://github.com/scikit-learn/scikit-learn/labels :)

@glemaitre glemaitre merged commit 6da44dd into scikit-learn:master Feb 27, 2020
@rth rth deleted the bug-triage branch February 28, 2020 08:42
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants