DOC Fix versionchanged in OneHotEncoder #16562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are in this file. Could you add the versionadded for the |
thomasjpfan
approved these changes
Apr 8, 2021
glemaitre
approved these changes
Apr 9, 2021
|
Thanks @rth |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
glemaitre
added a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15506 (comment)
To follow up on #15506 (comment) there was indeed a change of behaviour in OneHotEncoder in 0.20 (cf what's new) but I'm not convinced about the added value of something like,
added in 0.23 (i.e. mid 2020) for something that was relevant for the 0.19 -> 0.20 migration (i.e. mid 2018). For the vast majority of users that's not relevant. So I prefer to remove the versionchanged altogether.
cc @jnothman