[MRG] 0.22.2.post1 release branch #16609
Conversation
|
If nobody complains I will go with 0.22.2.post1 |
|
You also need to backport #16610 here. |
|
yes it's in my bullet list |
| @@ -156,7 +156,7 @@ <h4 class="sk-landing-call-header">News</h4> | |||
| <li><strong>On-going development:</strong> | |||
| <a href="https://scikit-learn.org/dev/whats_new.html"><strong>What's new</strong> (Changelog)</a> | |||
| </li> | |||
| <li><strong>February 2020.</strong> scikit-learn 0.22.2 is available for download (<a href="whats_new/v0.22.html#version-0-22-2">Changelog</a>). | |||
| <li><strong>March 2020.</strong> scikit-learn 0.22.2 is available for download (<a href="whats_new/v0.22.html#version-0-22-2">Changelog</a>). | |||
There was a problem hiding this comment.
Should we say "scikit-learn 0.22.2.post1" here ?
There was a problem hiding this comment.
Let's not put post here. It may lead to confusion.
There was a problem hiding this comment.
You could just say Fixed source distribution available from March
There was a problem hiding this comment.
Sorry don't get what you're proposing. Can you make it as a suggestion ?
There was a problem hiding this comment.
Sorry, I missed this ongoing discussion and already merged the PR. I believe this is fine as it is right?
There was a problem hiding this comment.
We can always update the website after the 0.22.2.post1 release by pushing to 0.22.X after the tag anyway.
|
Do we want to show the
|
|
If we want to remove the |
|
I'd rather remove it.
|
|
I included Thomas' fix for the display of the verison. Feel free to directly push more changes or merge if you're ok with the current state. I'll then tag and open a PR on macpython tomorrow. |
|
It seems to work as expected: https://95830-843222-gh.circle-artifacts.com/0/doc/index.html Merging! |
|
@jeremiedbb I let you tag 0.22.2.post1 and update the release PRs for MacPython / conda-forge? |
|
done |
|
Just a note, the 0.22.2.post1 release include a sdist while the 0.22.2 did not. It got picked by our CI running in Python 3.5 and crashed but I think Scikit-Learn 0.22.2 drop support for Python 3.5, correct? |
|
Yes, we don't support python 3.5 anymore.
…On Wed, Mar 4, 2020 at 2:40 PM Boris Feld ***@***.***> wrote:
Just a note, the 0.22.2.post1 release include a sdist while the 0.22.2 did
not. It got picked by our CI running in Python 3.5 and crashed but I think
Scikit-Learn 0.22.2 drop support for Python 3.5, correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16609?email_source=notifications&email_token=AAMWG6GNYOXZE2CBLOTJGLTRFZK3LA5CNFSM4K7P6BR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENX4P5Q#issuecomment-594528246>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMWG6E5LM5KLFQFP5RDI2DRFZK3LANCNFSM4K7P6BRQ>
.
|
That's not what setup.py for Related: #16636 |
|
I opened MacPython/scikit-learn-wheels#49 to generate wheels for python 3.5 |
|
Indeed, the incorrect information in the setup.py is breaking CIs (eg in nilearn I think that we need to do a post2 release with the right info in the setup.py |
|
No the setup.py is correct, 0.22 still support py35. It's just that py35 was removed from the build matrix on macpython. We're making the wheels and I'll upload them on pypi asap |
|
@GaelVaroquaux I uploaded the py35 wheels on pypi. It should be fine now |
|
@jeremiedbb : I restarted nilearn CI to see if things work now. |
|
It's green ! although you have flake8 issues :D |
|
Yup, but that's my problem. Thank you!! |
@adrinjalali here we go again :) New release after the failed 0.22.2 released last friday.
@scikit-learn/core-devs Do think it's better to do a 0.22.2.post1 or 0.22.3 ?
what happened with 0.22.2 ?
The 0.22.2 release failed because the sdist I uploaded on Pypi included the C files. I tried to remove it and upload it again but we can't upload a file with the same name twice.