Skip to content

DOC Fix "more..." link in "Model selection" section of 'index.html' #16620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

echasnovski
Copy link
Contributor

Reference Issues/PRs

No issues/PRs found about this problem.

What does this implement/fix? Explain your changes.

Changes what seems to be wrong link in 'index.html' document file to a correct one.

Any other comments?

New link was taken directly from section header imitating all other sections.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echasnovski I see this is your first time contributing, welcome!

I have a small comment. Otherwise this looks good. Thank you!

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
@echasnovski
Copy link
Contributor Author

Thank you, @thomasjpfan! Glad I could help.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 9766acd into scikit-learn:master Mar 3, 2020
@echasnovski echasnovski deleted the patch-1 branch March 3, 2020 20:14
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants