TST More stable test_uniform_grid #16621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
approved these changes
Mar 3, 2020
thomasjpfan
approved these changes
Mar 3, 2020
thomasjpfan
approved these changes
Mar 3, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix for #15821 (
test_uniform_gridfails on ppc64le and aarch64).By increasing the number of random seeds used in the test I could trigger similar failures on amd64. I then increased the perplexity to make the test easier. On amd64 this ensures that the test passes for all seeds in
range(100)(IIRC).Hopefully this will also make the tests pass on ppc64le and aarch64 although I have not tested because that would require setting up a local VM or new CI configuration.