TST Fixes test so that whole test isn't skipped if pandas not… #16627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As raised by @thomasjpfan in #14048, the remainder of the test will be skipped if pandas is not installed. This has been fixed in this PR by separating the test into two functions, on for arrays and one for dataframes.
As raised by @thomasjpfan in #14048, the remainder of the test will be skipped if pandas is not installed. This has been fixed in this PR by separating the test into two functions, on for arrays and one for dataframes.
…lrjball/scikit-learn into col_transformer_pandas_test_fix
thomasjpfan
approved these changes
Mar 4, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This issue was raised by @thomasjpfan in #14048 and this PR fixes a different test which has the same problem.
What does this implement/fix? Explain your changes.
pytest.importorskipis being used halfway down the test function, so if the import fails the whole test will be skipped. This PR splits the array and dataframe tests into two function, so that the array one can still pass even in pandas is not installed.