-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ENH Poisson loss for HistGradientBoostingRegressor #16692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3f800b5
PEP8 blank line after class docstring
78a2598
ENH add Poisson loss class to histogram gradient boosting
3480af0
TST add tests for Poisson loss class
60ec7f1
BUG hessians are not constant for Poisson loss
36da4bc
ENH add Poisson loss to HistGradientBoostingRegressor
7e4257e
TST test Poisson loss for HistGradientBoostingRegressor
e176d59
MNT rename poisson_loss to poisson
2c0343f
TST improve test_poisson for hist gradient boosting
047a5fb
MNT move up poisson loss to regression losses
2ba3dba
TST sanity check that sum(y)>0 for poisson
424b5d0
TST compare poisson baseline_prediction directly
9ff2d02
ENH check for invalid y for poisson in hist gradient boosting
96eba11
DOC add poisson loss to user guide
332d394
DOC mention log-link and y>=0 for poisson loss in hist gradient boosting
ebbf816
DOC whats new
48b54b7
DOC whats new wording
64da8c4
MNT remove wrong comment
54e3a75
MNT nitpicks
d9f7f55
Merge branch 'master' into hgb_poisson
84330a0
BUG check if fitted in predict of hist gradient boosting
fe60e24
MNT remove unnecessary np.empty_like
5e7a701
address review comments for tests
acc38ed
remove unused method Poisson.predict_target
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we taking advantage of this advantage somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I know of. Might be interesting to see, if it matters (at all).