[WIP] FIX remove validation from __init__ and set_param #16945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
commented
May 28, 2020
thomasjpfan
reviewed
May 28, 2020
|
Should this be MRG? Or is it waiting for something? |
|
The failing codecov is legit last time I checked, but I haven't gotten around to write the tests for them. |
|
@adrinjalali – is there anything you need to help get this finished? |
|
@proinsias there's a bit of work left here. But if you're interested, you can take a single estimator at a time, starting from the easier ones, and create a PR tackling them. Once I'll get back to this issue, I'll continue where you've left then. |
|
I would be happy to work on a couple of estimators to help here |
14 tasks
|
Closing as done in #21406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12652
This PR takes the approach of "validations in
__init__andset_paramshave been bugs and are fixed w/o a deprecation warning", and moves all validation/private attribute setting tofitor other relevant methods.