Skip to content

DOC Feature highlights for 0.23 #17062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 1, 2020

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Apr 27, 2020

CC @scikit-learn/core-devs please review or directly edit and add new entries as you please

CC @cmarmo too

@NicolasHug NicolasHug added this to the 0.23 milestone Apr 27, 2020
NicolasHug and others added 2 commits April 27, 2020 14:53
Co-Authored-By: Christian Lorentzen <lorentzen.ch@googlemail.com>
Co-Authored-By: Christian Lorentzen <lorentzen.ch@googlemail.com>
@adrinjalali
Copy link
Member

I think the positional deprecation also deserves to be here.

@jnothman
Copy link
Member

I think the positional deprecation also deserves to be here.

I'd be fine with this focusing on enhancements and new features.

HTML vis belongs here when merged.

sample_weight in Lasso and ElasticNet?

Changing away from Boston in examples? (a good media piece?)

Otherwise I suspect we're not going to list much more for this release. A lot of work behind the scenes for this one!!

print(reg.score(X_test, y_test))

##############################################################################
# Finally, users can now define :ref:`monotonic constraints
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for transparency, monotonic cst are in an example of their own after Joel's suggestion. It's not me trying to push my own PRs

@NicolasHug
Copy link
Member Author

Thanks Joel, I added a section about Lasso and ENet and separated the mnt_cst

Re positional stuff: I agree with Joel that this isn't really a feature. I feel like the top entry in the what's new would be enough

Re usage of Boston dataset: same, I feel like this would be a nice top-entry in the what's new, but not sure about including it in the highlights?

@cmarmo
Copy link
Contributor

cmarmo commented Apr 28, 2020

@NicolasHug, apparently people prefer the # %% syntax wrt ########... (#17063, and #17068), maybe it is worth it to start using it in new PRs?

@NicolasHug
Copy link
Member Author

yes, same for #16648

I'll update when / if the PR gets merge. I personally prefer the current form

@adrinjalali
Copy link
Member

I'd also happy to have the boston dataset change as a highlight here.

@jnothman
Copy link
Member

jnothman commented Apr 29, 2020 via email

@cmarmo
Copy link
Contributor

cmarmo commented Apr 29, 2020

But both these stories may be better told in a blog, @cmarmo?

Stories are always better told in a blog than in a software documentation, even if it is the best documentation in the world like yours ... ;)
Anyway, after the meeting I was under the impression that core-devs only want one reference for the 'what's new' communication, am I wrong?

@NicolasHug
Copy link
Member Author

Anyway, after the meeting I was under the impression that core-devs only want one reference for the 'what's new' communication, am I wrong?

My understanding was that if the foundation website is to have an article similar to this one for 0.23, then it should make clear that the "official" highlights are in the gallery, and link to it

I personally agree a blog post is better suited both for Boston and for the kwonly.

@jnothman
Copy link
Member

jnothman commented Apr 29, 2020 via email

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the ordering of the sections:

@NicolasHug
Copy link
Member Author

Comments addressed and added entry for html repr


clf = make_pipeline(preprocessor, LogisticRegression())
clf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to demonstrate a composite gaussian processes kernel too??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this can be done in the docs instead? I feel like a single example is enough, and we want the highlights to be short

Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
@NicolasHug
Copy link
Member Author

@ogrisel @thomasjpfan @rth @adrinjalali @glemaitre @jeremiedbb @TomDLT I think we can get this in now

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise +1.

@NicolasHug
Copy link
Member Author

Thanks @ogrisel @TomDLT , your comments were addressed

Will merge when green.

@GaelVaroquaux
Copy link
Member

Looks good to me.

Tiny nitpicks: I wouldn't do

plt.legend(); plt.show()

on the same line. It's not advised in Python styling.

Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
@NicolasHug NicolasHug changed the title [MRG] Feature highlights for 0.23 DOC Feature highlights for 0.23 May 1, 2020
@NicolasHug NicolasHug merged commit 863c1d6 into scikit-learn:master May 1, 2020
@NicolasHug NicolasHug deleted the release_highlights_023 branch May 1, 2020 15:06
@NicolasHug
Copy link
Member Author

@adrinjalali I'm not sure what PR I should ping anymore but this should be in the release ;)

@thomasjpfan
Copy link
Member

I guess we can continue pinging #17010

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 4, 2020
adrinjalali pushed a commit that referenced this pull request May 5, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants