FIX don't modify sample weight inplace in KMeans #17204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
May 13, 2020
rth
approved these changes
May 13, 2020
NicolasHug
approved these changes
May 13, 2020
| ...................... | ||
|
|
||
| - |Fix| Fixed a bug in :class:`cluster.KMeans` where the sample weights | ||
| provided by the user was modified in place. :pr:`17204` by |
There was a problem hiding this comment.
Suggested change
| provided by the user was modified in place. :pr:`17204` by | |
| provided by the user were modified in place. :pr:`17204` by |
| @@ -177,7 +177,7 @@ def _check_normalize_sample_weight(sample_weight, X): | |||
| # an array of 1 (i.e. samples_weight is None) is already normalized | |||
| n_samples = len(sample_weight) | |||
| scale = n_samples / sample_weight.sum() | |||
| sample_weight *= scale | |||
| sample_weight = sample_weight * scale | |||
There was a problem hiding this comment.
maybe make an explicit copy above instead?
|
I'll justmerge and will fix the typo in #17205 |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17203
KMeans scales sample weight to sum up to n_samples. It has been done inplace when we generalized the use of check_sample_weight.
@rth