Skip to content

Conversation

AdamSpannbauer
Copy link
Contributor

Reference Issues/PRs

I didn't find an open issue for this.

What does this implement/fix? Explain your changes.

Isomap documentation on the manifold module documentation incorrectly references the path_method argument:

The eigensolver can be specified by the user with the path_method keyword of Isomap.

This PR simply updates path_method to eigen_solver:

The eigensolver can be specified by the user with the eigen_solver keyword of Isomap.

Any other comments?

Link to Isomap source in case it's relevant.

@hugolmn
Copy link
Contributor

hugolmn commented May 14, 2020

Good job on spotting this mistake! Looks like it was copy-pasted from just above in the documentation

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you @AdamSpannbauer !

@thomasjpfan thomasjpfan merged commit 8595fe4 into scikit-learn:master May 14, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants