Skip to content

Conversation

lorentzenchr
Copy link
Member

What does this implement/fix? Explain your changes.

This PR improves the examples by fixing FutureWarnings currently present in the examples:

Some warnings may still remain.

Any other comments?

If a version 0.23.1 is planned, this would be a nice to have.

@thomasjpfan thomasjpfan added this to the 0.23.1 milestone May 18, 2020
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali adrinjalali merged commit 79b0943 into scikit-learn:master May 18, 2020
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
* MNT keyword only in examples

* MNT pandas 1.0.0 deprectation

See pandas-dev/pandas#23566

* MNT new keyword in 0.23
@lorentzenchr lorentzenchr deleted the example_kwd branch May 19, 2020 05:06
adrinjalali pushed a commit that referenced this pull request May 19, 2020
* MNT keyword only in examples

* MNT pandas 1.0.0 deprectation

See pandas-dev/pandas#23566

* MNT new keyword in 0.23
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
* MNT keyword only in examples

* MNT pandas 1.0.0 deprectation

See pandas-dev/pandas#23566

* MNT new keyword in 0.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants