Skip to content

Conversation

justmarkham
Copy link
Contributor

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

These are just minor documentation fixes that I noticed while reading through the site.

Any other comments?

No

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added this to the 0.23.2 milestone May 24, 2020
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @justmarkham

@thomasjpfan
Copy link
Member

Added to the 0.23.2 milestone for the docstring update in for the display keyword.

Copy link

@KumarGanesha1996 KumarGanesha1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justmarkham
Copy link
Contributor Author

You're welcome @thomasjpfan! Is there anything else I need to do, or is this ready to merge?

@thomasjpfan
Copy link
Member

This is ready to merge. Given this is a minor doc update, I'll merge now.

@thomasjpfan thomasjpfan merged commit 753da1d into scikit-learn:master May 28, 2020
@justmarkham justmarkham deleted the doc-fixes branch May 28, 2020 17:17
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants