ENH _fit_and_score now returns a dictionary #17332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
May 25, 2020
| fit_params=fit_params, | ||
| return_n_test_samples=True, | ||
| error_score=error_score) | ||
| return results["test_scores"], parameters, results["n_test_samples"] |
There was a problem hiding this comment.
Would it make sense to get the parameters from the dict?
Suggested change
| return results["test_scores"], parameters, results["n_test_samples"] | |
| return results["test_scores"], results["parameters"], results["n_test_samples"] |
There was a problem hiding this comment.
In this case, I would say no. return_parameters is set to false so parameters is not in the dict and fit_grid_point is deprecated.
| parameters : dict or None | ||
| The parameters that have been evaluated. | ||
| estimator : estimator object | ||
| The fitted estimator |
There was a problem hiding this comment.
Suggested change
| The fitted estimator | |
| The fitted estimator. |
|
We are going to have some git fun with some of the PR :) |
amueller
approved these changes
May 26, 2020
|
ping: merge conflicts |
|
I think that the documentation build was broken 😕. I am working to fix this as soon as possible! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jul 17, 2020
* ENH _fit_and_score now returns a dictionary * MRG * REV * LOL * Removing things in gitignore is fun
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* ENH _fit_and_score now returns a dictionary * MRG * REV * LOL * Removing things in gitignore is fun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #15126
What does this implement/fix? Explain your changes.
The goal of this PR is to make #15126 easily to review.