[WIP] Node bootstrap #17500
Closed
[WIP] Node bootstrap #17500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added random_state and n_samples Modified documentation to reflect default values Modified call to resample
amueller
reviewed
Jun 6, 2020
| @@ -565,7 +565,7 @@ def resample(*arrays, | |||
| return resampled_arrays | |||
|
|
|||
|
|
|||
| def shuffle(*arrays, **options): | |||
| def shuffle(*arrays, random_state=None, n_samples=None): | |||
There was a problem hiding this comment.
Thanks! Did you intentionally include this in this PR?
There was a problem hiding this comment.
No, was trying to figure out how to fix that. That was from a PR earlier today.
There was a problem hiding this comment.
Not intentionally ... It was supposed to be a second PR.
We are going to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#DataUmbrella
cc: @ab-anssi
Reference Issues/PRs
Issue #11993
What does this implement/fix? Explain your changes.
@ab-anssi and I wanted to use a trivial example to test the functionality of splitting training data at the tree level, but even this hard-coded and minimally invasive example broke the unit tests without delivering acceptable functionality. Do you have any other input or guidance on the right way to implement this or corrections to our approach?
Any other comments?