DOC: updated documentation for n_jobs in _graph.py #DataUmbrella #17513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#DataUmbrella sprint |
thomasjpfan
reviewed
Jun 7, 2020
Comment on lines
+163
to
+164
| The number of jobs to run in parallel; the k-nearest neighbor | ||
| computations are performed parallel to each other. |
There was a problem hiding this comment.
Thank you for the PR!
I think the original is clear enough about what n_jobs is used for.
Aside: radius_neighbors_graph finds the neighbors in a given radius.
There was a problem hiding this comment.
Thanks for the feedback! We can leave it as it is then. Also thanks for the clarification.
|
So we can close this PR then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs:
#14228
What does this implement/fix? Explain your changes.
As part of the #dataumbrella June sprint, I updated documentation for n_jobs in _graph.py to better reflect where parallelization is being applied
Any other comments?
Pair programming partner: @krumeto