Skip to content

MNT Deprecate X_idx_sorted in tree module #17614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2020
Merged

MNT Deprecate X_idx_sorted in tree module #17614

merged 4 commits into from
Jun 17, 2020

Conversation

alfaro96
Copy link
Member

Reference Issues/PRs

Closes #16818.
Related with #14907.

What does this implement/fix? Explain your changes.

With the deprecation of the presort hyper-parameter, the use of the X_idx_sorted in the fit method has no longer effect.

This PR X_idx_sorted from the ensemble and tree module and deprecates from public API.

glemaitre
glemaitre approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Could you add an entry in what's new?

@alfaro96
Copy link
Member Author

Thanks @glemaitre for the review!

I have already committed the suggested changes.

thomasjpfan
thomasjpfan reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @alfaro96 !

@alfaro96
Copy link
Member Author

Thank you for the PR @alfaro96 !

Thank you for the review @thomasjpfan!

thomasjpfan
thomasjpfan approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit e4ebcbc into scikit-learn:master Jun 17, 2020
@alfaro96 alfaro96 deleted the deprecate_X_idx_sorted_tree branch June 18, 2020 15:10
dsandeep0138 pushed a commit to dsandeep0138/scikit-learn that referenced this pull request Jun 21, 2020
@alfaro96 @dsandeep0138
MNT Deprecate X_idx_sorted in tree module (scikit-learn#17614)
bc2c9b1
rubywerman pushed a commit to MLH-Fellowship/scikit-learn that referenced this pull request Jun 24, 2020
@alfaro96 @rubywerman
MNT Deprecate X_idx_sorted in tree module (scikit-learn#17614)
8123153
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@alfaro96 @viclafargue
MNT Deprecate X_idx_sorted in tree module (scikit-learn#17614)
b62e4e5
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
MNT Deprecate X_idx_sorted in tree module (scikit-learn#17614)
8e6c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:ensemble module:tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused parameter X_idx_sorted in tree classifiers
3 participants
@alfaro96 @thomasjpfan @glemaitre