Documentation of attributes of HistGradientBoostingClassifier #17678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jun 23, 2020
There was a problem hiding this comment.
Thanks for taking care of this @cmarmo , some minor comments
| @@ -1109,6 +1111,8 @@ class HistGradientBoostingClassifier(BaseHistGradientBoosting, | |||
| ---------- | |||
| classes_ : array, shape = (n_classes,) | |||
| Class labels. | |||
| do_early_stopping_ : bool | |||
There was a problem hiding this comment.
We'll also need this for the regressor
There was a problem hiding this comment.
Right, @simonamaggio is taking care of that in #17677.
There was a problem hiding this comment.
it'd be easier to have everything in the same PR so that we can ensure consistency, but OK
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
glemaitre
reviewed
Jun 24, 2020
NicolasHug
approved these changes
Jun 24, 2020
|
Labeled as 'superseded' @simonamaggio will take care of the changes for |
|
Thanks @cmarmo |
|
@glemaitre wrong PR... this is superseded by #17677 |
|
Uhm we need both. One is the classifier, the other one is the regressor. |
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
…learn#17678) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jul 17, 2020
…learn#17678) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…learn#17678) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #16283
Related to #14312
What does this implement/fix? Explain your changes.
Documents missing attribute
do_early_stopping, makes private some other previously undocumented attributes (see comment)