DOC add missing attributes in GaussianProcessClassifier (#14312) #17698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#14312) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com>
…into doc_attributes
lesteve
reviewed
Jun 24, 2020
sklearn/gaussian_process/_gpc.py
Outdated
| @@ -555,6 +555,10 @@ def optimizer(obj_func, initial_theta, bounds): | |||
|
|
|||
| Attributes | |||
| ---------- | |||
| base_estimator_ : ``_BinaryGaussianProcessClassifierLaplace`` | |||
There was a problem hiding this comment.
The type description seems a bit overcomplicated. Maybe use Estimator instead?
There was a problem hiding this comment.
Yeah, we will do. We had doubts about the naming :)
lesteve
reviewed
Jun 24, 2020
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
…cikit-learn into doc_attributes
glemaitre
reviewed
Jun 24, 2020
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
…#17698) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jul 17, 2020
…#17698) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…#17698) Co-authored-by: Beatriz San Miguel <beatriz.sanmiguelgonzalez@uk.fujitsu.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues
Add attributes for the GaussianProcessClassifier #14312.
What does this implement/fix? Explain your changes.
Add description for
base_estimator_attribute.Any other comments?
Co-authored-by: Beatriz San Miguel (beatriz.sanmiguelgonzalez@uk.fujitsu.com)