Skip to content

MNT Fix extension for sphinx 3.0 #17724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jun 25, 2020

Reference Issues/PRs

Fixes doc build bug introduced in #13022

(Sphinx changed the structure of app.events.listeners in sphinx-doc/sphinx@2e338aa)

CC @adrinjalali

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy if circle ci is happy.

@glemaitre
Copy link
Member

@ogrisel is happy then :)

@glemaitre glemaitre merged commit dad615a into scikit-learn:master Jun 25, 2020
@glemaitre
Copy link
Member

Thanks @thomasjpfan It is cool to have CIs that work :)

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants