Skip to content

ENH Uses binned values from training to find missing values #17736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 16, 2020
Merged

ENH Uses binned values from training to find missing values #17736

merged 7 commits into from
Jul 16, 2020

Conversation

thomasjpfan
Copy link
Member

Fixes issue from #16883

adrinjalali
adrinjalali approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasjpfan , could you please merge with the latest master and them we merge? (don't want to make the same mistake somehow :P)

@adrinjalali adrinjalali merged commit 1f7053f into scikit-learn:master Jul 16, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@thomasjpfan @jayzed82
ENH Uses binned values from training to find missing values (scikit-l…
432d726 
…earn#17736)

* ENH Uses training data to find missing values

* CLN Uses the binned data to find missing value

* ENH Uses binned values from training to find missing values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasjpfan @adrinjalali