Skip to content

MNT Removed arguments from matplotlib.use() #17774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2020
Merged

MNT Removed arguments from matplotlib.use() #17774

merged 1 commit into from
Jul 6, 2020

Conversation

acharles7
Copy link
Contributor

@acharles7 acharles7 commented Jun 29, 2020 •
edited
Loading

Reference Issues/PRs

Fixes #17751

What does this implement/fix? Explain your changes.

Removed warn and force arguments from matplotlib.use('agg', warn=False, force=True) which cause MatplotlibDeprecationWarning and made it default.

Any other comments?

matplotlib.use()

@acharles7 acharles7 closed this Jun 29, 2020
@acharles7 acharles7 changed the title Removed warn and arguments Removed arguments from matplotlib.use() Jun 29, 2020
@acharles7 acharles7 reopened this Jun 29, 2020
@acharles7
Copy link
Contributor Author

@glemaitre Can you please review it? TIA

@acharles7 acharles7 force-pushed the matplotlib_warning branch from c117179 to ce3c4e0 Compare June 30, 2020 17:10
@acharles7
Copy link
Contributor Author

@glemaitre Please have a look at it when you get a chance. Thank you

thomasjpfan
thomasjpfan approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @acharles7 !

LGTM

@jnothman jnothman changed the title Removed arguments from matplotlib.use() MNT Removed arguments from matplotlib.use() Jul 6, 2020
@jnothman jnothman merged commit d273591 into scikit-learn:master Jul 6, 2020
@jnothman
Copy link
Member

jnothman commented Jul 6, 2020

Thanks, @acharles7

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@acharles7 @glemaitre
MNT Removed arguments from matplotlib.use() (scikit-learn#17774)
c4f718a
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 3, 2020
@acharles7 @glemaitre
MNT Removed arguments from matplotlib.use() (scikit-learn#17774)
659aaa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MNT MatplotlibDeprecationWarning by using use
3 participants
@acharles7 @jnothman @thomasjpfan