Skip to content

FIX Change MRO for some estimators #17837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 5, 2020
Merged

FIX Change MRO for some estimators #17837

merged 4 commits into from
Jul 5, 2020

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Jul 5, 2020 •
edited
Loading

Reference Issues/PRs

Fixes #17836.
Merge required to continue working on #17806.
Continuation from #14884.

What does this implement/fix? Explain your changes.

This PR changes the MRO for LogisticRegression and LogisticRegressionCV.

@alfaro96 alfaro96 changed the title FIX Fix requires_y tag for LogisticRegression(CV) FIX Change MRO for LogisticRegression and LogisticRegressionCV Jul 5, 2020
@alfaro96
Copy link
Member Author

alfaro96 commented Jul 5, 2020

Quick review @rth?

@rth
Copy link
Member

rth commented Jul 5, 2020

Would you also mind fixing the other few cases from #17836 (comment) ?

@alfaro96
Copy link
Member Author

alfaro96 commented Jul 5, 2020

Would you also mind fixing the other few cases from #17836 (comment) ?

It would a pleasure!

In fact, I need this to be fixed before continue working on #17806.

@alfaro96 alfaro96 changed the title FIX Change MRO for LogisticRegression and LogisticRegressionCV FIX ContChange MRO for LogisticRegression and LogisticRegressionCV Jul 5, 2020
@alfaro96 alfaro96 changed the title FIX Change MRO for LogisticRegression and LogisticRegressionCV FIX ContChange MRO for LogisticRegression and LogisticRegressionCV Jul 5, 2020
@alfaro96 alfaro96 changed the title FIX ContChange MRO for LogisticRegression and LogisticRegressionCV FIX Change MRO for some estimators Jul 5, 2020
rth
rth approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alfaro96, LGTM. Will merge on green CI.

@alfaro96
Copy link
Member Author

alfaro96 commented Jul 5, 2020

Thanks @alfaro96, LGTM. Will merge on green CI.

Thanks @rth!

If you do not mind, I will add a few more to avoid future errors in #17806.

@alfaro96
Copy link
Member Author

alfaro96 commented Jul 5, 2020 •
edited
Loading

I think that I have fixed the remaining ones. Let us wait now for the green in the CI.

Thanks @rth for your quickness and patience!

@rth rth merged commit 9cd13a1 into scikit-learn:master Jul 5, 2020
@rth
Copy link
Member

rth commented Jul 5, 2020

Thanks @alfaro96 !

@alfaro96 alfaro96 deleted the fix_tags_logistic_regression branch July 5, 2020 11:53
@alfaro96 alfaro96 mentioned this pull request Jul 5, 2020
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Jul 17, 2020
@alfaro96 @glemaitre
FIX Change MRO for some estimators (scikit-learn#17837)
ac95b60
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@alfaro96 @jayzed82
FIX Change MRO for some estimators (scikit-learn#17837)
60561d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong estimator tags for LogisticRegression
2 participants
@alfaro96 @rth