Skip to content

[MRG] DOC Revamp statistical inference tutorial pages #17865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[MRG] DOC Revamp statistical inference tutorial pages #17865

wants to merge 13 commits into from

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented Jul 8, 2020 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR update the display style of statistical inference pages:

Currently images and codeblocks have issues and the pages are not responsive at all.

Any other comments?

Contents haven't been modified, only the rendering has changed.

@cmarmo cmarmo changed the title DOC Revamp supervised learning tutorial page [WIP] DOC Revamp tutorial pages Jul 10, 2020
@cmarmo cmarmo changed the title [WIP] DOC Revamp tutorial pages [WIP] DOC Revamp statistical inference tutorial pages Jul 10, 2020
@cmarmo cmarmo changed the title [WIP] DOC Revamp statistical inference tutorial pages [MRG] DOC Revamp statistical inference tutorial pages Jul 11, 2020
@cmarmo cmarmo mentioned this pull request Jul 14, 2020
Merged
adrinjalali
adrinjalali reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. I did see this PR (after I had merged the other one) and decided not to say anything mostly due to the fact that I understand no html or css. I liked the other one since it introduced nothing I didn't understand, it was just moving the code block a little bit, and it kinda made sense.

I think this is a very valid solution, and as long as there are enough people in the team who understand html and/or css, I think it's pretty good. But I'm personally not somebody who can review or maintain these bits.

doc/tutorial/statistical_inference/supervised_learning.rst
@@ -53,6 +53,22 @@ Nearest neighbor and the curse of dimensionality
>>> np.unique(iris_y)
array([0, 1, 2])

.. raw :: html

</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with these examples and the code block being too narrow I guess.

@cmarmo
Copy link
Contributor Author

cmarmo commented Jul 14, 2020 •
edited
Loading

Thanks @adrinjalali for your answer. I have created the div and not only moved the plot because all the plots were originally aligned to right, making me think that the original idea was to have the code on the left and the image on the right and the restyling changed the rendering.
If everybody is happy with the simple solution (code block above the plot), this is indeed much more comfortable.
Perhaps @thomasjpfan could have a look? Thanks.

@thomasjpfan thomasjpfan self-assigned this Jul 15, 2020
@cmarmo
Copy link
Contributor Author

cmarmo commented Jul 16, 2020

@thomasjpfan I'm closing this one: @chaitanyamogal is taking care of this section of the tutorial.

@cmarmo cmarmo closed this Jul 16, 2020
@thomasjpfan
Copy link
Member

@cmarmo okay!

This was referenced Aug 25, 2020
Open
Merged
@cmarmo cmarmo deleted the sup_learning_doc branch July 11, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali left review comments

Assignees

@thomasjpfan thomasjpfan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmarmo @thomasjpfan @adrinjalali