Skip to content

removed os import #17893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2020
Merged

removed os import #17893

merged 1 commit into from
Jul 11, 2020

Conversation

biprateep
Copy link
Contributor

Reference Issues/PRs

Fixes one import issue from #12167

What does this implement/fix? Explain your changes.

Removed an unnecessary os import from root/conftest.py

Any other comments?

amueller
amueller approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GaelVaroquaux
Copy link
Member

LGTM. Merging when tests have passed

@GaelVaroquaux
Copy link
Member

All green. Merging. Thank you!

@GaelVaroquaux GaelVaroquaux merged commit 19b2daa into scikit-learn:master Jul 11, 2020
@biprateep biprateep deleted the code-hygene branch July 11, 2020 16:46
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@biprateep @jayzed82
removed os import (scikit-learn#17893)
b15dbde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@amueller amueller amueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biprateep @GaelVaroquaux @amueller