Skip to content

MNT Fixed import statements #17901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2020
Merged

Conversation

biprateep
Copy link
Contributor

Reference Issues/PRs

Fixes import statements from #12167 (LGTM)

What does this implement/fix? Explain your changes.

  • Fixes redundant import os statements
  • Brings import numpy and os statements out of a function and puts them at the top of the file

Any other comments?

@amueller
Copy link
Member

The linting is failing here.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @biprateep !

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaelVaroquaux
Copy link
Member

OK, merging. Thanks

@GaelVaroquaux GaelVaroquaux merged commit 8274820 into scikit-learn:master Jul 11, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
* fixed import statements

* fixed linting issues

* keep numpy import within setup_module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants