Remove redundant typing import #18004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the LGTM error alert for `A module is imported with the "import" and "import from" statements`
|
This is weird: this import line is longer than 80 chars and the linter does not complain. |
|
Should I change that line to something like this? |
|
I would rather avoid the parens and split on two lines with repeated imports to minimize conflict probabilities: from typing import TYPE_CHECKING
from typing import Any, Dict, Iterator, List, Optional, Tuple, Union |
Modified length of import statement to meet length constraints
rth
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Thanks! We generally don't modify vendored files (in externals/ folder) and they are typically not linted.
In this case it's fine to modify it, as we had to change these lines when adding typing to openml fetcher in #17053 and we still need to contribute them upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Progress towards #12167.
What does this implement/fix? Explain your changes.
This removes the LGTM error alert
A module is imported with the "import" and "import from" statementsAny other comments?