Skip to content

DOC Add Feature engine to Related Projects page #18012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020
Merged

DOC Add Feature engine to Related Projects page #18012

merged 2 commits into from
Aug 3, 2020

Conversation

solegalli
Copy link
Contributor

Hi team!

A small addition to the Related Projects page. I suggest the inclusion of Feature-engine. I brought this you your attention last year in the email list. The package includes transformers for missing data imputation, categorical encoding, variable transformation and discretisation and outlier handling. While many of these techniques are contemplated in the SimpleImputer, PowerTransformer, FunctionTransformer and KBinsDiscretiser, Feature-engine includes some additional imputation, encoding and discretisation techniques not yet present in sklearn. And it allows the user to select which variables to modify within the transfomer (like the package category-encoders), which is (my opinion) quite handy. Fully compatible with the sklearn Pipeline, and with quite extensive documentation :)

Let me know if you would be happy to have this addition to the list. Thank you!

@rth
Copy link
Member

rth commented Jul 31, 2020

Thanks @solegalli the package sounds quite useful and the addition looks good to me, however formatting needs to be fixed. Currently CircleCI fails while building docs with,

+ '[' '/home/circleci/project/doc/related_projects.rst:229: WARNING: Bullet list ends without a blank line; unexpected unindent.' '!=' '/home/circleci/project/ no warnings' ']'
+ echo 'Sphinx generated warnings when building the documentation related to files modified in this PR.'
Sphinx generated warnings when building the documentation related to files modified in this PR.

I think you need to add more indentation as in other entries.

@solegalli
Copy link
Contributor Author

@rth thank you for the tip! Fixed indentation. Glad to hear package makes a good addition :)

@rth rth merged commit cf30ec8 into scikit-learn:master Aug 3, 2020
@solegalli solegalli deleted the featureengine branch August 3, 2020 14:52
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Co-authored-by: Soledad Galli <solegalli1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants