-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
FIX Convergence Warnings in Gaussian process examples #18019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Description of the warnings: The following modules under
|
Detailed description of my work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @marenwestermann !
1.0 * RationalQuadratic(length_scale=1.0, alpha=0.1, | ||
alpha_bounds=(1e-5, 1e6)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still getting the same number of convergence warnings with this change. Lets revert this for now and keep the other change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…8019) Co-authored-by: Maren Westermann <maren.westermann@free-now.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Maren Westermann <maren.westermann@free-now.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…8019) Co-authored-by: Maren Westermann <maren.westermann@free-now.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Reference Issues/PRs
Fixes convergence warnings mentioned in #17946
See also #17943 and #12673
What does this implement/fix? Explain your changes.
This implementation fixes convergence warnings in
examples/gaussian_process/*
introduced through #12673Any other comments?
I tried to fix all convergence warnings but I wasn't successful. I will detail what I have done so far below.