Skip to content

DOC add section on debugging ARM64 problems #18033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2020
Merged

DOC add section on debugging ARM64 problems #18033

merged 4 commits into from
Jul 30, 2020

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jul 30, 2020

New section to explain how to debug ARM64 related stuff on a traditional x64_64 machine using QEMU, docker and miniforge.

This is indenpendent of the CI config at #17996 but a good complement for local dev and debugging.

/cc @rth @glemaitre and @thomasjpfan.

NicolasHug
NicolasHug approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ogrisel, LGTM though I haven't reproduced the steps!

@rth
Copy link
Member

rth commented Jul 30, 2020 •
edited
Loading

Thanks @ogrisel . Maybe not put it under "advanced installation instructions" but rather "Developers’ Tips and Tricks", as it's not really about installing on ARM64, but rather how to emulate ARM on x86_64.

And also maybe replacing Building and testing for the ARM64 platform with Building and testing for the ARM64 platform using x86_64. We definitely want to avoid people on RaspberryPi or ARM servers trying to install scikit-learn in qemu ^^ We can certainly mention miniforge for installs with ARM/PPC64le under "advanced installations instructions" but maybe not qemu?

Another comment is that instructions for ppc64le are essentially the same after a change of the docker image arch and miniforge download link. So maybe

Building and testing for the ARM64 or ppc64le  platforms using x86_64

... note: The following instructions are illustrated for ARM64 but they also apply to ppc64le, 
             after changing Docker image and Miniforge paths appropriately.

ARM-based machines are a popular target ...

we also get a fair amount of ppc64le issues

@ogrisel
Copy link
Member Author

ogrisel commented Jul 30, 2020

@rth good points. PR updated accordingly.

rth
rth approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 863b5ba into scikit-learn:master Jul 30, 2020
@ogrisel ogrisel deleted the doc-debug-arm64 branch July 31, 2020 07:20
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@ogrisel @jayzed82
DOC add section on debugging ARM64 problems (scikit-learn#18033)
f256ff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @rth @NicolasHug