remove comparison of identical variables #18036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
remove Variable defined multiple times in examples/linear_model/plot_poisson_regression_non_normal_loss.py |
|
The arff package is an external package and your changes should be contributed there: https://github.com/renatopp/liac-arff |
>>> np.nan != np.nan
True |
|
Thought, it would be better to use |
rth
reviewed
Jul 31, 2020
There was a problem hiding this comment.
Sorry closing, as mentioned above this change should be contributed to https://github.com/renatopp/liac-arff
| @@ -77,7 +77,7 @@ | |||
| .format(df.loc[df["ClaimNb"] == 0, "Exposure"].sum() / | |||
| df["Exposure"].sum())) | |||
|
|
|||
| fig, (ax0, ax1, ax2) = plt.subplots(ncols=3, figsize=(16, 4)) | |||
| _, (ax0, ax1, ax2) = plt.subplots(ncols=3, figsize=(16, 4)) | |||
There was a problem hiding this comment.
Even here, I'm not sure it's a positive change.
fig, ax = plt.subplots(...)
is more readable than,
_, ax = ..
particularly in an example even if fig is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12167
What does this implement/fix? Explain your changes.
remove comparison of identical variables in sklearn/externals/_arff.py
Any other comments?