ENH follow-up style improvements of DET curves #10591 #18169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @cmarmo @agramfort @jnothman who reviewed #10591 |
|
We should open an issue to add the |
NicolasHug
reviewed
Aug 16, 2020
| @@ -1,7 +1,7 @@ | |||
| """ | |||
| ======================================= | |||
| ==================================== | |||
There was a problem hiding this comment.
should this be in metric instead of model_selection ?
There was a problem hiding this comment.
The plot_roc is also in this section. I am not sure what is best. I think that the idea is to compare model and select the best one in some sense. So it is not so wrong to put it in this section.
|
There's also the "False Negative Rate" ylabel that overlaps with the left plot in the example. |
6 tasks
|
ping @lorentzenchr @rth as well :P |
NicolasHug
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Don't know how to add a review comment to the following:
- In the docstring of
detection_error_tradeoff_curve, replace "Note: This metrics is used for ranking evaluation of a binary" by "This metric is used for evaluation of ranking and error tradeoffs of a binary". - In the User Guide, can we replace the word "ordinate" by "y-axis"?
|
@lorentzenchr Done |
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
|
Good to be merged :) |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…ikit-learn#18169) * follow-up on scikit-learn#10591 * DOC improvements * TST add additional test for pos_label Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10591.
Closes #18174.