FIX Correctly sets MDS pairwise attribute #18278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaro96
approved these changes
Aug 27, 2020
| @@ -364,7 +367,7 @@ Changelog | |||
| - |Enhancement| :class:`multiclass.OneVsOneClassifier` now accepts | |||
| the inputs with missing values. Hence, estimators which can handle | |||
| missing values (may be a pipeline with imputation step) can be used as | |||
| a estimator for multiclass wrappers. | |||
| a estimator for multiclass wrappers. | |||
There was a problem hiding this comment.
This was done with a pre-commit hook. (I normally revert these types of commits, but these slipped through).
| @@ -386,7 +386,7 @@ def __init__(self, n_components=2, *, metric=True, n_init=4, | |||
|
|
|||
| @property | |||
| def _pairwise(self): | |||
| return self.kernel == "precomputed" | |||
| return self.dissimilarity == "precomputed" | |||
There was a problem hiding this comment.
I suppose that this attribute was not tested because kernel is not an (hyper)parameter in sklearn.manifold.MDS.
There was a problem hiding this comment.
I do not know why this was not tested. There was nothing in the test suite that actually used the _pairwise property.
jnothman
approved these changes
Aug 27, 2020
|
Good catch |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found while working on #18143