DOC Clarify shape in OVO and OVR decision function docstring #18279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Aug 27, 2020
sklearn/multiclass.py
Outdated
| @@ -412,7 +412,8 @@ def decision_function(self, X): | |||
|
|
|||
| Returns | |||
| ------- | |||
| T : array-like of shape (n_samples, n_classes) | |||
| T : array-like of shape (n_samples, n_classes) or (n_samples,) if \ | |||
There was a problem hiding this comment.
Suggested change
| T : array-like of shape (n_samples, n_classes) or (n_samples,) if \ | |
| T : array-like of shape (n_samples, n_classes) or (n_samples,) for \ |
sklearn/multiclass.py
Outdated
| @@ -687,7 +688,8 @@ def decision_function(self, X): | |||
|
|
|||
| Returns | |||
| ------- | |||
| Y : array-like of shape (n_samples, n_classes) | |||
| Y : array-like of shape (n_samples, n_classes) or (n_samples,) if \ | |||
There was a problem hiding this comment.
Suggested change
| Y : array-like of shape (n_samples, n_classes) or (n_samples,) if \ | |
| Y : array-like of shape (n_samples, n_classes) or (n_samples,) for \ |
Point taken. I was just initially confused by the version changed note |
I think it has to do with #9100 . |
|
Thanks @lucyleeow |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Clarify shape in OVR and OVO docstring
Any other comments?